-
Notifications
You must be signed in to change notification settings - Fork 439
mark the BumpPtrAllocator class as @_spi(BumpPtrAllocator). #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make sure that swift-syntax builds with this change? There are a couple of references to BumpPtrAllocator
within the swift-syntax package that now no longer work. You will need to add @_spi(BumpPtrAllocator)
to the imports in those files as well.
just to confirm, in the swift-syntax repo, inside the sources folder, inside the swiftSyntax folder, I need to include the which files exactly should I add this import statement? when I do a search in vscode for |
If you run a build (either in your editor or just You'll need to update those to use |
whenever I try running I have checked that |
Oh, that's odd. I have never seen this issue before. A couple of questions:
|
okay, I got it. had to reinstall my Xcode. |
41e9acf
to
bc6afe7
Compare
I squashed the commits. |
@_spi(RawSyntax) import SwiftSyntax | ||
@_spi(BumpPtrAllocator) import SwiftSyntax |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we prefer to pile up the attributes on a single import.
… @_spi(RawSyntax)
4070982
to
a2fe6b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏽
@swift-ci Please test |
@swift-ci Please test Windows |
@swift-ci Please test |
mark the BumpPtrAllocator class as @_spi(BumpPtrAllocator) instead of @_spi(RawSyntax).
resolves the issue #68351 (swiftlang/swift#68351)